Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2522: Update jcommander from 1.48 to 1.78 #2523

Merged
merged 2 commits into from Dec 23, 2020
Merged

Issue 2522: Update jcommander from 1.48 to 1.78 #2523

merged 2 commits into from Dec 23, 2020

Conversation

anvinjain
Copy link
Contributor

@anvinjain anvinjain commented Dec 19, 2020

Descriptions of the changes in this PR:

Motivation

Certain bookkeeper shell commands when bookkeeper is bundled with pulsar because of conflicting jcommander versions

Changes

Updates jcommander to 1.78, same as pulsar.

Master Issue: #2522

@anvinjain anvinjain marked this pull request as draft December 19, 2020 04:08
@anvinjain anvinjain marked this pull request as ready for review December 22, 2020 11:03
@anvinjain
Copy link
Contributor Author

@eolivelli @sijie This fixes #2522

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Ghatage @sijie please merge to branch 4.12.
After this change we are ready to cut 4.12.1 as soon as possible

@anvinjain anvinjain changed the title Issue 2522: [WIP] Update jcommander from 1.48 to 1.78 Issue 2522: Update jcommander from 1.48 to 1.78 Dec 22, 2020
@Ghatage Ghatage added this to the 4.13.0 milestone Dec 23, 2020
@Ghatage Ghatage merged commit 6866b51 into apache:master Dec 23, 2020
@anvinjain anvinjain deleted the jcmd-1.78-update branch December 24, 2020 03:51
eolivelli pushed a commit that referenced this pull request Dec 28, 2020
Descriptions of the changes in this PR:



### Motivation
Certain bookkeeper shell commands when bookkeeper is bundled with pulsar because of conflicting jcommander versions

### Changes
Updates jcommander to 1.78, same as pulsar.

Master Issue: #2522 

Reviewers: Enrico Olivelli <eolivelli@gmail.com>

This closes #2523 from anvinjain/jcmd-1.78-update, closes #2522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants